[flang-commits] [PATCH] D113086: [flang] Add a semantics test for co_reduce

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added inline comments.


================
Comment at: flang/test/Semantics/collectives05.f90:41
+    ! the error is seen as too many arguments to the co_reduce() call
+    !ERROR: too many actual arguments for intrinsic 'co_reduce'
+    call co_reduce(i, int_op, result_image=1, stat=status, errmsg=message, 3.4)
----------------
ekieri wrote:
> Please start error messages with a captial letter, as per [1]. (I suppose that overrides [2], which requires the opposite.) Same things on line 45. 
> 
> [1] https://flang.llvm.org/docs/C++style.html#error-messages
> [2] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages
@rouson is not creating error messages here, he is matching the error message that will be produced by the compiler once collectives have been added to the list of intrinsics. If the error message not beginning with a capital letter is an issue, the source code that currently procedures this message would need to be edited. I personally would think that that might be outside the scope of this patch, as it is just adding a test, not editing source code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086