[flang-commits] [PATCH] D114104: [FIR] Convert fir.allocmem and fir.freemem operations to calls to malloc and free, respectively

[Alexis Perry-Holby via Phabricator via flang-commits]

AlexisPerry marked 6 inline comments as done.
AlexisPerry added a comment.

Fix a couple namespacing errors



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:245
 
+namespace {
+/// Helper function for generating the LLVM IR that computes the size
----------------
mehdi_amini wrote:
> AlexisPerry wrote:
> > mehdi_amini wrote:
> > > AlexisPerry wrote:
> > > > clementval wrote:
> > > > > I think it's already in an anonymous namespace.
> > > > Thanks for the catch!
> > > The coding standard indicates that anonymous namespace should be made as small as possible and only include class declarations.
> > > Functions should be made static and outside the namespace instead.
> > > 
> > > https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
> > Thank you for the review.  I think I have implemented your suggestions correctly, but I would appreciate it if you could verify.  There were a number of places I had to change that were outside of the particular part of the file I had been working on and I want to make sure I captured everything appropriately.
> Just pointed two places, otherwise LG
Thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114104/new/

https://reviews.llvm.org/D114104