[flang-commits] [PATCH] D114063: [fir] Add fir.constc conversion

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: flang/test/Fir/convert-to-llvm.fir:695
+
+func @test_constc() -> !fir.complex<4> {
+  %0 = fir.constc (#fir.real<4, 1.4>, #fir.real<4, 2.3>) : !fir.complex<4>
----------------
rovka wrote:
> kiranchandramohan wrote:
> > I think we do not have this op in fir-ops.fir where we check all the ops. Could you add a similar one there as well?
> Great idea, I'll send a separate patch because we actually hit an unreachable while printing constc 
OK


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114063/new/

https://reviews.llvm.org/D114063