[flang-commits] [PATCH] D114063: [fir] Add fir.constc conversion

[Valentin Clement via Phabricator via flang-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1654
     mlir::OwningRewritePatternList pattern(context);
     pattern.insert<
         AbsentOpConversion, AddcOpConversion, AddrOfOpConversion,
----------------
tschuett wrote:
> Would it help to  put `// clang-format off` around this block, with one entry per line. It is hard to see the real diff.
It's changing a lot recently because we are upstreaming the conversion patterns. Once we are done it will not change much so I don't think we need to format it differently. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114063/new/

https://reviews.llvm.org/D114063