[flang-commits] [PATCH] D113563: [fir] Add !fir.alloca conversion

[Eric Schweitz via Phabricator via flang-commits]

schweitz added a comment.

In D113563#3123923 <https://reviews.llvm.org/D113563#3123923>, @rovka wrote:

> Less auto.
> Also replace TODO with error, although I'm not sure who should be generating the mem size function. If it's this pass, then TODO sounds better, but if it's supposed to already exist in the module by the time this pass runs then error is more appropriate. Maybe @schweitz or @jeanPerier can chime in.

Lowering needs to create the function.

`TODO` is really an error with a grep-able name. It merely adds the magic text "not yet implemented", but is otherwise the same functionality.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113563/new/

https://reviews.llvm.org/D113563