[flang-commits] [PATCH] D113273: [fir] TargetRewrite: Rewrite COMPLEX values

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/TargetRewrite.cpp:263
+          })
+          .template Case<mlir::ComplexType>([&](mlir::ComplexType cmplx) {
+            rewriteCallComplexInputType(cmplx, oper, newInTys, newOpers);
----------------
I tried to add a test with mlir::ComplexType, but it told me that the dialect is not registered. It doesn't seem to be registered in fir-dev AFAICT (I hope I'm looking in [[ https://github.com/flang-compiler/f18-llvm-project/blob/080bcac68a39ffa7c9bad4f1df6144965c430687/flang/include/flang/Optimizer/Support/InitFIR.h#L35 | the right place ]]). Does flang ever actually use mlir::ComplexType, or should I remove this code path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113273/new/

https://reviews.llvm.org/D113273