[flang-commits] [PATCH] D113076: [flang] Add a semantics test for co_sum

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added a comment.

I have locally implemented `co_sum` and was able to get this test to pass if these two error messages are changed, and if the python program is added, as suggested by @kiranchandramohan. Is there a way to make this test expectedly fail to get it into the repository? And then I can submit a patch with my implementation of `co_sum` in `flang/lib/Evaluate/intrinsics.cpp`?



================
Comment at: flang/test/Semantics/collectives01.f90:36
+    ! the error is seen as too many arguments to the co_sum() call
+    !ERROR: too many actual arguments for collective subroutines 'co_sum'
+    call co_sum(i,   result_image=1, stat=status, errmsg=message, 3.4)
----------------
The expected error will be `too many actual arguments for intrinsic 'co_sum'`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113076/new/

https://reviews.llvm.org/D113076