[flang-commits] [flang] 8cd199b - [flang] Accept OPEN(ACCESS='APPEND') legacy extension even without warnings enabled

[peter klausler via flang-commits]

Author: peter klausler
Date: 2021-05-18T11:32:52-07:00
New Revision: 8cd199b85f907a7349bc5cb1b3d3562e0e79b72c

URL: https://github.com/llvm/llvm-project/commit/8cd199b85f907a7349bc5cb1b3d3562e0e79b72c
DIFF: https://github.com/llvm/llvm-project/commit/8cd199b85f907a7349bc5cb1b3d3562e0e79b72c.diff

LOG: [flang] Accept OPEN(ACCESS='APPEND') legacy extension even without warnings enabled

My earlier patch to accept ACCESS='APPEND' only worked when warnings
were enabled; fix it.

Differential Revision: https://reviews.llvm.org/D102653

Added: 
    

Modified: 
    flang/lib/Semantics/check-io.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Semantics/check-io.cpp b/flang/lib/Semantics/check-io.cpp
index c0eeeafd8ace9..0f93deea0e9e9 100644
--- a/flang/lib/Semantics/check-io.cpp
+++ b/flang/lib/Semantics/check-io.cpp
@@ -833,10 +833,12 @@ void IoChecker::CheckStringValue(IoSpecKind specKind, const std::string &value,
   };
   auto upper{parser::ToUpperCaseLetters(value)};
   if (specValues.at(specKind).count(upper) == 0) {
-    if (specKind == IoSpecKind::Access && upper == "APPEND" &&
-        context_.languageFeatures().ShouldWarn(
-            common::LanguageFeature::OpenAccessAppend)) {
-      context_.Say(source, "ACCESS='%s' interpreted as POSITION='%s'"_en_US, value, upper);
+    if (specKind == IoSpecKind::Access && upper == "APPEND") {
+      if (context_.languageFeatures().ShouldWarn(
+              common::LanguageFeature::OpenAccessAppend)) {
+        context_.Say(source, "ACCESS='%s' interpreted as POSITION='%s'"_en_US,
+            value, upper);
+      }
     } else {
       context_.Say(source, "Invalid %s value '%s'"_err_en_US,
           parser::ToUpperCaseLetters(common::EnumToString(specKind)), value);