[flang-commits] [PATCH] D99198: [flang] Fix output buffering bug

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

LGTM. Thanks Peter for fixing this quickly.



================
Comment at: flang/runtime/buffer.h:31
+//
+// Possible scenario with a tiny 32-byte buffer after a ReadFrame or
+// WriteFrame with a file offset of 103 to access "DEF":
----------------
This detailed explanation is helpful.


================
Comment at: flang/runtime/buffer.h:177
 
+  void MakeDataContiguous(IoErrorHandler &handler, std::size_t bytes) {
+    if (static_cast<std::int64_t>(start_ + bytes) > size_) {
----------------
Nice function and inline documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99198/new/

https://reviews.llvm.org/D99198