[flang-commits] [PATCH] D97119: [flang][driver] Add options for -std=f2018

[Arnamoy B via Phabricator via flang-commits]

arnamoy10 added inline comments.


================
Comment at: flang/test/Driver/std2018.f90:1
+! REQUIRES: new-flang-driver
+! Ensure argument -std=f2018 works as expected.
----------------
awarzynski wrote:
> Would it be possible to share this test with `f18`?
Would you please elaborate on how do want the sharing to happen (same test file/different test file)?  I think in a previous comment you mentioned that it is sufficient to test the frontend driver for this patch?


================
Comment at: flang/test/Driver/std2018_wrong.f90:14-22
+subroutine foo2()
+    do 01 m=1,2
+      select case (m)
+      case default
+        print*, "default", m
+      case (1)
+        print*, "start"
----------------
awarzynski wrote:
> No input is needed for this test, is it? IIUC, this bit can be deleted to make the test leaner.
Sure, will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97119/new/

https://reviews.llvm.org/D97119