[flang-commits] [PATCH] D97580: [flang] Runtime: SCAN and VERIFY

[Jean Perier via Phabricator via flang-commits]

jeanPerier accepted this revision.
jeanPerier added a comment.
This revision is now accepted and ready to land.

Logic looks good to me. Please take care of the Pre-merge checks if they make sense.



================
Comment at: flang/runtime/character.cpp:273
+    for (std::size_t j{0}; j < setLen; ++j) {
+      unsigned setCh{set[j] & 0xff};
+      bitSet[setCh / 64] |= static_cast<std::uint64_t>(1) << (setCh % 64);
----------------
Given the logic of the code, the 3 narrowing warnings from clang-tidy do not look harmful to me, but I think it might be worth adding explicit casts/removing the initializer list to avoid compiler warnings here.


================
Comment at: flang/runtime/character.cpp:305
+          : set.rank()   ? set.rank()
+          : back         ? back->rank()
+                         : 0};
----------------
Is this clang-format warning coming from a clang-format version difference ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97580/new/

https://reviews.llvm.org/D97580