[flang-commits] [PATCH] D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.

sameeran joshi via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Jan 21 06:14:33 PST 2021


sameeranjoshi updated this revision to Diff 318176.
sameeranjoshi added a comment.

Summary of changes:

- Refactor and simplify the algorithm without changes in parser.
- Added 2 routines for code cleanup, and help extended for the later checks. `ChecksOnOrderedAsStandalone` `ChecksOnOrderedAsBlock`
- Use `FindClause` to replace manual traversal of `OmpClauseList`. `FindClause` didn't work inside `Leave(const parser::OpenMPBlockConstruct &)` as the `DirectiveContext`  gets reset before we reach the node. Hence checks are now done in `Leave(const parser::OmpBeginBlockDirective &)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94087/new/

https://reviews.llvm.org/D94087

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/lib/Semantics/resolve-directives.cpp
  flang/test/Semantics/omp-clause-validity01.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94087.318176.patch
Type: text/x-patch
Size: 11784 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20210121/1d5fdacb/attachment-0001.bin>


More information about the flang-commits mailing list