[flang-commits] [PATCH] D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi updated this revision to Diff 316387.
sameeranjoshi added a comment.

Ideally in the first look the checks would fit better for ordered construct
inside a single function `CheckDependOnOrderedDir` so we have them at a
single place , unfortunately it's harder to implement it in above function
considering that the information to differentiate between a
`OmpBlockDirective` and `OmpSimpleStandaloneDirective` is unavailable.

Hence the approach of checks inside the respective nodes was choosen.
Using `FindClause` doesn't work for some reason hence reverting to the old
school way of finding manually inside a list of `OmpClause`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94087/new/

https://reviews.llvm.org/D94087

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/lib/Semantics/resolve-directives.cpp
  flang/test/Semantics/omp-clause-validity01.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94087.316387.patch
Type: text/x-patch
Size: 11943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20210113/298e5af6/attachment-0001.bin>