[flang-commits] [PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi marked 7 inline comments as done.
sameeranjoshi added a comment.

These are great catches, thank you.
I was wondering since the merge of `task_reduction` why were the tests failing and did kept this on hold for a while since then.
Thanks again. :)



================
Comment at: flang/test/Semantics/omp-taskgroup01.f90:39
+      print *, "The "
+      !$omp taskgroup task_reduction(min, reduction_var)
+      !$omp taskgroup task_reduction(min, reduction_var)
----------------
kiranchandramohan wrote:
> A colon (not comma) is expected right?
Ideally it was supposed to be caught in parser itself, unfortunately it didn't.
May be this needs to be investigated in new patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93373/new/

https://reviews.llvm.org/D93373