[flang-commits] [PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/test/Semantics/omp-taskgroup01.f90:37
+  !$omp parallel
+    !$omp taskgroup task_reduction(+, reduction_var)
+      print *, "The "
----------------
reduction_var is not declared?


================
Comment at: flang/test/Semantics/omp-taskgroup01.f90:48
+      !$omp end taskgroup
+      !$omp end task
+      !$omp taskgroup task_reduction(-, xyz) task_reduction(-, xyz)
----------------
Should this be taskgroup or is this accidentally added?


================
Comment at: flang/test/Semantics/omp-taskgroup01.f90:51
+      !$omp end taskgroup
+    !$omp end taskgroup
+  !$omp end parallel
----------------
Check count of begin and end taskgroups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93373/new/

https://reviews.llvm.org/D93373