[flang-commits] [PATCH] D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi updated this revision to Diff 315156.
sameeranjoshi added a comment.

Summary of changes:

- Fix core dump in ordered construct due to missing tree node visit

for `OpenMPSimpleStandaloneConstruct` as ordered with a depend falls under it.

- Fix internal error in name resolution of depend clause.

Internal error for Critical construct seems to get fixed with this code change.
Not really sure how does that fix, but this will be revisited in D93051 <https://reviews.llvm.org/D93051>.

This diff doesn't yet work on the review comments so as to avoid confusions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94087/new/

https://reviews.llvm.org/D94087

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/lib/Semantics/resolve-directives.cpp
  flang/test/Semantics/omp-clause-validity01.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94087.315156.patch
Type: text/x-patch
Size: 5482 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20210107/5c9421ce/attachment.bin>