[flang-commits] [flang] cf47163 - [flang][driver] Add missing dependency in unit tests (nfc)

Andrzej Warzynski via flang-commits flang-commits at lists.llvm.org
Wed Feb 10 05:33:03 PST 2021


Author: Andrzej Warzynski
Date: 2021-02-10T13:31:49Z
New Revision: cf471632b1bd02d6f6e582c8c0f82043f7d09946

URL: https://github.com/llvm/llvm-project/commit/cf471632b1bd02d6f6e582c8c0f82043f7d09946
DIFF: https://github.com/llvm/llvm-project/commit/cf471632b1bd02d6f6e582c8c0f82043f7d09946.diff

LOG: [flang][driver] Add missing dependency in unit tests (nfc)

The following patch revealed a missing dependency in the CMake script
for Flang driver unit tests:
  * https://reviews.llvm.org/D96032
The following buildbots are failing ("BUILD_SHARED_LIBS" is set to ON):
  * http://lab.llvm.org:8011/#/builders/134/builds/1840
  * http://lab.llvm.org:8011/#/builders/66/builds/1785
  * http://lab.llvm.org:8011/#/builders/33/builds/2436

This patch adds the missing dependency.

>From what I can see, FortranSemantics and FortranParser are only
indirect dependencies of FlangFrontendTests and IIUC shouldn't be
required here. This is something that we should revisit at some point.
In this patch I focus on fixing the build.

Added: 
    

Modified: 
    flang/unittests/Frontend/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/flang/unittests/Frontend/CMakeLists.txt b/flang/unittests/Frontend/CMakeLists.txt
index 7b507b326621..88ec86f49291 100644
--- a/flang/unittests/Frontend/CMakeLists.txt
+++ b/flang/unittests/Frontend/CMakeLists.txt
@@ -9,4 +9,5 @@ target_link_libraries(FlangFrontendTests
   flangFrontend
   flangFrontendTool
   FortranParser
+  FortranSemantics
 )


        


More information about the flang-commits mailing list