[flang-commits] [PATCH] D115735: [flang] Make f18 build with GCC 11.2.0 and with --std=c++20

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/CMakeLists.txt:113
     message("LLVM configuration set a C++ standard: ${LLVM_CXX_STD}")
-    if (NOT LLVM_CXX_STD EQUAL "c++17")
+    if (NOT LLVM_CXX_STD EQUAL "c++17" AND NOT LLVM_CXX_STD EQUAL "c++20")
       message("Flang: Overriding LLVM's 'cxx_std' setting...")
----------------
klausler wrote:
> rovka wrote:
> > Nit: How about if (NOT LLVM_CXX_STD EQUAL CMAKE_CXX_STANDARD)?
> Only one of them has a "c++" prefix, so they would never compare equal.
Right. Also, EQUAL is for "numbers", we should use STREQUAL: if (NOT LLVM_CXX_STD STREQUAL "c++${CMAKE_CXX_STANDARD}").


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115735/new/

https://reviews.llvm.org/D115735