[flang-commits] [PATCH] D113086: [flang] Add a semantics test for co_reduce

[Emil Kieri via Phabricator via flang-commits]

ekieri added a comment.

Thanks for addressing my comments! I noted an oversight inline, and wonder about the intended test coverage, otherwise this looks good I think.

In your update note, you say that all statically checkable restrictions are covered. However, a few are still missing if I'm not mistaken. For example, I do not see any checks for polymorphic 'A', or type parameters for the arguments and result of 'operation'. Also, the semantics of 'result_image', 'stat', and 'errmsg' appear untested. Not a blocker for me. As @kiranchandramohan said, we can build up the tests over time. But if you commit it incomplete, please include a comment describing its coverage.

'stat' and 'errmsg' appear as arguments in several intrinsics with the same constraints. Could it be preferable to check them, for all intrinsics where they appear, in a separate test? If so, it would be good to reference that test from here with a comment (todo-note for now, I presume).



================
Comment at: flang/test/Semantics/collectives05.f90:94
+  !ERROR: (message to be determined)
+  call co_reduce(i, type_mismatch)
+
----------------
This function is not defined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086