[flang-commits] [PATCH] D114943: [flang] Return arrays in Transfer runtime with SIZE argument

[Jean Perier via Phabricator via flang-commits]

jeanPerier marked 2 inline comments as done.
jeanPerier added inline comments.


================
Comment at: flang/runtime/misc-intrinsic.cpp:26
       CFI_attribute_allocatable, mold.Addendum() != nullptr);
   if (rank > 0) {
+    result.GetDimension(0).SetBounds(1, *resultExtent);
----------------
klausler wrote:
> I know this is safe, but future code readers might be misled by the (apparently) unprotected reference to the value of resultExtent here.  Can you change the if() predicate to "if (resultExtent)"?
Fair point, I changed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114943/new/

https://reviews.llvm.org/D114943