[flang-commits] [PATCH] D114943: [flang] Return arrays in Transfer runtime with SIZE argument

[Peter Klausler via Phabricator via flang-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/runtime/misc-intrinsic.cpp:17
 namespace Fortran::runtime {
 extern "C" {
 
----------------
The "extern "C"" can be after the (now) static first function.


================
Comment at: flang/runtime/misc-intrinsic.cpp:26
       CFI_attribute_allocatable, mold.Addendum() != nullptr);
   if (rank > 0) {
+    result.GetDimension(0).SetBounds(1, *resultExtent);
----------------
I know this is safe, but future code readers might be misled by the (apparently) unprotected reference to the value of resultExtent here.  Can you change the if() predicate to "if (resultExtent)"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114943/new/

https://reviews.llvm.org/D114943