[flang-commits] [PATCH] D113086: [flang] Add a semantics test for co_reduce

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added a comment.

> Great, thanks, as you are working on that I see no issue. I also thought that 'Unexpectedly Passed' was unlikely to trigger due to differences in the error messages, but as all messages are pre-existing (as you kindly pointed out) I admit this risk is small. But still, good that you are working on the checks!

Since I have a little experience looking into the flang source code, as @rouson was writing his tests, I made some changes locally so that I could provide him with the error messages that would occur once the intrinsic he was working on was added to flang. However, you make a great point that I hadn't thought through that, if the error messages the test expects were wrong, then once a developer adds that intrinsic, the test would continue to expectedly fail, rather than unexpectedly pass. Since I am planning on working on these, this doesn't seem to be a concern, but it is a good possibility to be aware of, thanks for the feedback!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086