[flang-commits] [PATCH] D108931: [flang] Fold CSHIFT

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

I had one comment in fold-implementation.h.  Otherwise, all builds, tests, and looks good.

Thanks for doing this!



================
Comment at: flang/lib/Evaluate/fold-implementation.h:557-559
+  if (!array || !shiftExpr || !dim) {
+    return Expr<T>{std::move(funcRef)};
+  }
----------------
Can you move this code down below after you get the "shift" variable below and avoid the "if" statement at line 563?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108931/new/

https://reviews.llvm.org/D108931