[flang-commits] [PATCH] D108687: [flang] Add runtime interface for COMMAND_ARGUMENT_COUNT

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/runtime/command.h:9
+
+#ifndef FORTRAN_RUNTIME_COMMAND_H_
+#define FORTRAN_RUNTIME_COMMAND_H_
----------------
klausler wrote:
> rovka wrote:
> > That's weird, it's suggesting LLVM_FLANG_RUNTIME_COMMAND_H, but none of the other headers in the runtime have that kind of include guard (there are 3 FLANG_RUNTIME_*_H and plenty of FORTRAN_RUNTIME_*_H). The C++ style document isn't very specific on this either. What's the preference?
> > 
> > That's weird, it's suggesting LLVM_FLANG_RUNTIME_COMMAND_H, but none of the other headers in the runtime have that kind of include guard (there are 3 FLANG_RUNTIME_*_H and plenty of FORTRAN_RUNTIME_*_H). The C++ style document isn't very specific on this either. What's the preference?
> > 
> 
> Our header guards correspond to namespaces, so FORTRAN_*_H.
Ok, so the file should be fine then. I don't think we can tune the clang-tidy check for this, and we probably don't want to disable it altogether since then we'd miss out on real issues (i.e. missing header guards). Should I just commit as-is? Or does anyone have any other comments?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108687/new/

https://reviews.llvm.org/D108687