[flang-commits] [PATCH] D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics

[Peter Klausler via flang-commits]

That's valid (and required) usage, so we seem to have run into a problem with MSVC.  I'll change the patch to omit the use of the keyword "template" here, but if that doesn't work, we'll have to just disable all this code for MSVC for now and figure the best solution out later.

-----Original Message-----
From: مهدي شينون (Mehdi Chinoune) via Phabricator <reviews at reviews.llvm.org> 
Sent: Friday, April 2, 2021 12:16 PM
To: Peter Klausler <pklausler at nvidia.com>
Cc: llvm-commits at lists.llvm.org; jdoerfert at anl.gov; flang-commits at lists.llvm.org; Renaud Kauffmann <rkauffmann at nvidia.com>; bhuvanendra.kumarn at amd.com; 88888yl at gmail.com; gsocsameeran at gmail.com; Peter Steinfeld <psteinfeld at nvidia.com>; aperry at lanl.gov; Jean Perier <jperier at nvidia.com>; Timothy Keith <tkeith at nvidia.com>; clementval at gmail.com; sourabhsingh.tomar at amd.com; dougpuob at gmail.com; Steve Scalpone <sscalpone at nvidia.com>; isuruf at gmail.com; kiranchandramohan at gmail.com; Eric Schweitz <eschweitz at nvidia.com>; v.churavy at gmail.com
Subject: [PATCH] D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics

External email: Use caution opening links or attachments


MehdiChinoune added a comment.

I get this error:

  D:\dev\llvm-project\flang\runtime\reduction.cpp(95): error C2059: syntax error: 'template'
  D:\dev\llvm-project\flang\runtime\reduction.cpp(404): note: see reference to function template instantiation 'signed char Fortran::runtime::GetTotalReduction<Fortran::common::TypeCategory::Integer,1,Fortran::runtime::IntegerSumAccumulator<int>>(const Fortran::runtime::Descriptor &,const char *,int,int,const Fortran::runtime::Descriptor *,ACCUMULATOR &&,const char *)' being compiled
          with
          [
              ACCUMULATOR=Fortran::runtime::IntegerSumAccumulator<int>
          ]

Could you fix it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD99806%2Fnew%2F&data=04%7C01%7Cpklausler%40nvidia.com%7Ca8756420aead4c2d99ae08d8f60bb7fd%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637529877500766922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2IVk2QdtlYrWV581n5sDWhcFwCmt8ktcP4DFiXROO1s%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD99806&data=04%7C01%7Cpklausler%40nvidia.com%7Ca8756420aead4c2d99ae08d8f60bb7fd%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637529877500766922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fwHOzP46JHtruwhryTqpopliEhuHEbtNi9gdCcytUqw%3D&reserved=0