[flang-commits] [PATCH] D99666: [flang] Implement reductions in the runtime

Fri Apr 2 07:45:47 PDT 2021

Patch is coming.

-----Original Message-----
From: مهدي شينون (Mehdi Chinoune) via Phabricator <reviews at reviews.llvm.org> 
Sent: Friday, April 2, 2021 3:19 AM
To: Peter Klausler <pklausler at nvidia.com>; Eric Schweitz <eschweitz at nvidia.com>; Jean Perier <jperier at nvidia.com>; Steve Scalpone <sscalpone at nvidia.com>
Cc: mehdi.chinoune at hotmail.com; kparzysz at quicinc.com; llvm-commits at lists.llvm.org; mgorny at gentoo.org; pengfei.wang at intel.com; jdoerfert at anl.gov; flang-commits at lists.llvm.org; Renaud Kauffmann <rkauffmann at nvidia.com>; bhuvanendra.kumarn at amd.com; 88888yl at gmail.com; gsocsameeran at gmail.com; Peter Steinfeld <psteinfeld at nvidia.com>; aperry at lanl.gov; Timothy Keith <tkeith at nvidia.com>; clementval at gmail.com; sourabhsingh.tomar at amd.com; dougpuob at gmail.com; isuruf at gmail.com; kiranchandramohan at gmail.com; v.churavy at gmail.com
Subject: [PATCH] D99666: [flang] Implement reductions in the runtime

External email: Use caution opening links or attachments

MehdiChinoune added a comment.

This commit breaks Building on MSVC.

================
Comment at: flang/lib/Decimal/binary-to-decimal.cpp:353

-#if __x86_64__ && !defined(_MSC_VER)
 ConversionToDecimalResult ConvertLongDoubleToDecimal(char *buffer,
----------------
MehdiChinoune wrote:
> Did you test this commit with MSVC before removing these conditions.
> Because it fails with MSVC.
> Did you test this commit with MSVC before removing these conditions.
> Because it fails with MSVC.

this condition should be replaced by #ifdef LONG_DOUBLE

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD99666%2Fnew%2F&data=04%7C01%7Cpklausler%40nvidia.com%7Cb649e8de29594c332f6308d8f5c0c71e%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637529555626342635%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Tru5pjmpE400Q4ob%2F%2BlkNikDYD9zJgcZ3iV%2Flc5kzlU%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD99666&data=04%7C01%7Cpklausler%40nvidia.com%7Cb649e8de29594c332f6308d8f5c0c71e%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637529555626342635%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gXCfuhLgLnJpFErSols4rDOoQv%2FS%2F1SQ0AMh0fb0kW4%3D&reserved=0