[flang-commits] [PATCH] D88504: [flang][msvc] Workaround 'forgotten' symbols FoldOperation. NFC.

[Peter Klausler via Phabricator via flang-commits]

klausler accepted this revision.
klausler added a comment.
This revision is now accepted and ready to land.

If the magic MSVC option works around this compiler bug, and perhaps others, it seems to me like a cleaner way to avoid their problems.



================
Comment at: flang/lib/Evaluate/fold-implementation.h:1160
         using Operand = ResultType<decltype(kindExpr)>;
+        TypeCategory constexpr FromCat = FROMCAT;
         char buffer[64];
----------------
Please conform to our conventional use of braced initialization, and consider adding a comment that the new constexpr is a MSVC work-around, or it'll be susceptible to being removed as redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88504/new/

https://reviews.llvm.org/D88504