[flang-commits] [PATCH] D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct.

Kiran Chandramohan via Phabricator via flang-commits flang-commits at lists.llvm.org
Sat Sep 26 07:51:08 PDT 2020


kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-acc-structure.cpp:62
   }
+  bool Pre(const parser::DoConstruct &doConstruct) {
+    const auto &doStmt{
----------------
clementval wrote:
> sameeranjoshi wrote:
> > clementval wrote:
> > > I guess they are others construct that can have a label. 
> > Do you mean collecting labels from all the statements in the block?
> > 
> I don't have an example right here but it's probable that an exit statement can exit to other constructs label than `DoConstruct`. 
Can you check lib/Semantics/check-do-forall.cpp for similar functionality? Particularly, the following functions.
void DoForallChecker::Enter(const parser::ExitStmt &exitStmt) {
  CheckNesting(StmtType::EXIT, common::GetPtrFromOptional(exitStmt.v));
}
void DoForallChecker::CheckNesting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87906/new/

https://reviews.llvm.org/D87906



More information about the flang-commits mailing list