[flang-commits] [PATCH] D88163: [flang][msvc] Avoid templated initializer list initialization of vector. NFC.

[Michael Kruse via Phabricator via flang-commits]

Meinersbur updated this revision to Diff 293799.
Meinersbur retitled this revision from "[flang][msvc] Avoid ctor initializer list population of vector. NFC." to "[flang][msvc] Avoid templated initializer list initialization of vector. NFC.".
Meinersbur edited the summary of this revision.
Meinersbur added a comment.

Just avoiding the template is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88163/new/

https://reviews.llvm.org/D88163

Files:
  flang/include/flang/Evaluate/constant.h


Index: flang/include/flang/Evaluate/constant.h
===================================================================
--- flang/include/flang/Evaluate/constant.h
+++ flang/include/flang/Evaluate/constant.h
@@ -97,8 +97,7 @@
 
   template <typename A>
   ConstantBase(const A &x, Result res = Result{}) : result_{res}, values_{x} {}
-  template <typename A, typename = common::NoLvalue<A>>
-  ConstantBase(A &&x, Result res = Result{})
+  ConstantBase(ELEMENT &&x, Result res = Result{})
       : result_{res}, values_{std::move(x)} {}
   ConstantBase(
       std::vector<Element> &&, ConstantSubscripts &&, Result = Result{});


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88163.293799.patch
Type: text/x-patch
Size: 624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20200923/c665c772/attachment-0001.bin>