[flang-commits] [flang] dfa9065 - [NFCI][flang] Renamed a variable name to a more descriptive name

Sourabh Singh Tomar via flang-commits flang-commits at lists.llvm.org
Wed Sep 23 05:53:42 PDT 2020


Author: Sourabh Singh Tomar
Date: 2020-09-23T18:21:05+05:30
New Revision: dfa9065ad778fe830245e627c7fd9e39f2045bc9

URL: https://github.com/llvm/llvm-project/commit/dfa9065ad778fe830245e627c7fd9e39f2045bc9
DIFF: https://github.com/llvm/llvm-project/commit/dfa9065ad778fe830245e627c7fd9e39f2045bc9.diff

LOG: [NFCI][flang] Renamed a variable name to a more descriptive name

Added: 
    

Modified: 
    flang/lib/Lower/OpenMP.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/OpenMP.cpp b/flang/lib/Lower/OpenMP.cpp
index d8e5812388ef..75ddfba65e67 100644
--- a/flang/lib/Lower/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP.cpp
@@ -21,7 +21,7 @@
 
 #define TODO() llvm_unreachable("not yet implemented")
 
-static void genOMP(Fortran::lower::AbstractConverter &absConv,
+static void genOMP(Fortran::lower::AbstractConverter &converter,
                    Fortran::lower::pft::Evaluation &eval,
                    const Fortran::parser::OpenMPSimpleStandaloneConstruct
                        &simpleStandaloneConstruct) {
@@ -32,16 +32,16 @@ static void genOMP(Fortran::lower::AbstractConverter &absConv,
   default:
     break;
   case llvm::omp::Directive::OMPD_barrier:
-    absConv.getFirOpBuilder().create<mlir::omp::BarrierOp>(
-        absConv.getCurrentLocation());
+    converter.getFirOpBuilder().create<mlir::omp::BarrierOp>(
+        converter.getCurrentLocation());
     break;
   case llvm::omp::Directive::OMPD_taskwait:
-    absConv.getFirOpBuilder().create<mlir::omp::TaskwaitOp>(
-        absConv.getCurrentLocation());
+    converter.getFirOpBuilder().create<mlir::omp::TaskwaitOp>(
+        converter.getCurrentLocation());
     break;
   case llvm::omp::Directive::OMPD_taskyield:
-    absConv.getFirOpBuilder().create<mlir::omp::TaskyieldOp>(
-        absConv.getCurrentLocation());
+    converter.getFirOpBuilder().create<mlir::omp::TaskyieldOp>(
+        converter.getCurrentLocation());
     break;
   case llvm::omp::Directive::OMPD_target_enter_data:
     TODO();
@@ -55,14 +55,14 @@ static void genOMP(Fortran::lower::AbstractConverter &absConv,
 }
 
 static void
-genOMP(Fortran::lower::AbstractConverter &absConv,
+genOMP(Fortran::lower::AbstractConverter &converter,
        Fortran::lower::pft::Evaluation &eval,
        const Fortran::parser::OpenMPStandaloneConstruct &standaloneConstruct) {
   std::visit(
       Fortran::common::visitors{
           [&](const Fortran::parser::OpenMPSimpleStandaloneConstruct
                   &simpleStandaloneConstruct) {
-            genOMP(absConv, eval, simpleStandaloneConstruct);
+            genOMP(converter, eval, simpleStandaloneConstruct);
           },
           [&](const Fortran::parser::OpenMPFlushConstruct &flushConstruct) {
             TODO();
@@ -77,7 +77,7 @@ genOMP(Fortran::lower::AbstractConverter &absConv,
 }
 
 static void
-genOMP(Fortran::lower::AbstractConverter &absConv,
+genOMP(Fortran::lower::AbstractConverter &converter,
        Fortran::lower::pft::Evaluation &eval,
        const Fortran::parser::OpenMPBlockConstruct &blockConstruct) {
   const auto &blockDirective =
@@ -85,8 +85,8 @@ genOMP(Fortran::lower::AbstractConverter &absConv,
   const auto &parallelDirective =
       std::get<Fortran::parser::OmpBlockDirective>(blockDirective.t);
   if (parallelDirective.v == llvm::omp::OMPD_parallel) {
-    auto &firOpBuilder = absConv.getFirOpBuilder();
-    auto currentLocation = absConv.getCurrentLocation();
+    auto &firOpBuilder = converter.getFirOpBuilder();
+    auto currentLocation = converter.getCurrentLocation();
     auto insertPt = firOpBuilder.saveInsertionPoint();
 
     // Clauses.
@@ -99,7 +99,7 @@ genOMP(Fortran::lower::AbstractConverter &absConv,
       if (const auto &numThreadsClause =
               std::get_if<Fortran::parser::OmpClause::NumThreads>(&clause.u)) {
         // OMPIRBuilder expects `NUM_THREAD` clause as a `Value`.
-        numThreads = absConv.genExprValue(
+        numThreads = converter.genExprValue(
             *Fortran::semantics::GetExpr(numThreadsClause->v));
       }
     }
@@ -122,7 +122,7 @@ genOMP(Fortran::lower::AbstractConverter &absConv,
 }
 
 void Fortran::lower::genOpenMPConstruct(
-    Fortran::lower::AbstractConverter &absConv,
+    Fortran::lower::AbstractConverter &converter,
     Fortran::lower::pft::Evaluation &eval,
     const Fortran::parser::OpenMPConstruct &ompConstruct) {
 
@@ -130,7 +130,7 @@ void Fortran::lower::genOpenMPConstruct(
       common::visitors{
           [&](const Fortran::parser::OpenMPStandaloneConstruct
                   &standaloneConstruct) {
-            genOMP(absConv, eval, standaloneConstruct);
+            genOMP(converter, eval, standaloneConstruct);
           },
           [&](const Fortran::parser::OpenMPSectionsConstruct
                   &sectionsConstruct) { TODO(); },
@@ -138,7 +138,7 @@ void Fortran::lower::genOpenMPConstruct(
             TODO();
           },
           [&](const Fortran::parser::OpenMPBlockConstruct &blockConstruct) {
-            genOMP(absConv, eval, blockConstruct);
+            genOMP(converter, eval, blockConstruct);
           },
           [&](const Fortran::parser::OpenMPAtomicConstruct &atomicConstruct) {
             TODO();


        


More information about the flang-commits mailing list