[flang-commits] [PATCH] D86131: [FLANG] Pick `.md` files when building sphinx documentation.

Hans Wennborg via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Sep 9 05:10:16 PDT 2020


hans added a comment.

In D86131#2263071 <https://reviews.llvm.org/D86131#2263071>, @sameeranjoshi wrote:

> Hi @hans 
> The problem here is the version of recommonmark.
> We strictly need version `0.5.0` or above.
> See the `note` at https://www.sphinx-doc.org/en/master/usage/markdown.html#configuration
> and https://github.com/llvm/llvm-project/blob/0fd425af071a9bc5c0891a4db09f4d9a466b7be9/flang/docs/conf.py#L44
>
> I tried with the mentioned version and I can see the comments in the HTML files.
> @sscalpone as well has verified it with `recommonmark 0.6.0 version`
>
> Hopefully, @hans if you can verify it with a sample comment on your machine then I can revert the old patch `D86875` and bring back licence text.
>
> Thanks.

I don't have version 0.5.0 or above (I use the Debian package), but put the comment back in and I'll deal with it locally in my build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86131/new/

https://reviews.llvm.org/D86131



More information about the flang-commits mailing list