[flang-commits] [PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.

sameeran joshi via Phabricator via flang-commits flang-commits at lists.llvm.org
Sat Oct 31 12:26:34 PDT 2020


sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:343
+  void ResolveOmpName(const parser::Name &, Symbol::Flag);
+  Symbol *ResolveName(const parser::Name *);
   Symbol *DeclareOrMarkOtherAccessEntity(const parser::Name &, Symbol::Flag);
----------------
clementval wrote:
> So in the end you didn't need `resolve-names` and an easy resolve name inside resolve directive was doable...
Yes :), hopefully when I debugged how the actual resolution occurs.
But in later patches we might end up with needless repetition of code for fortran and OMP/OACC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90538/new/

https://reviews.llvm.org/D90538



More information about the flang-commits mailing list