[flang-commits] [PATCH] D89879: [Flang][OpenMP] Parsing and semantic changes for flush construct from OMP 5.0 specification.

[Valentin Clement via Phabricator via flang-commits]

clementval added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:423
 def OMP_Flush : Directive<"flush"> {
-  let allowedClauses = [
+  let allowedOnceClauses = [
     VersionedClause<OMPC_AcqRel, 50>,
----------------
sameeranjoshi wrote:
> clementval wrote:
> > sameeranjoshi wrote:
> > > clementval wrote:
> > > > Did you check if clang test are still passing with this change? 
> > > With `ninja check-clang check-flang` all seems well.
> > > I can't figure out why bots failed in applying the patch.
> > > @Reviewers can someone conform if this patch applies and build and tests well?
> > Which bot do you see failing? 
> From[1] I specifically failing[2] to apply patch.
> 
> [1] https://reviews.llvm.org/harbormaster/build/99908/
> [2] https://buildkite.com/llvm-project/diff-checks/builds/16004
Looks like it a conflict problem. You should rebase one more time. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89879/new/

https://reviews.llvm.org/D89879