[flang-commits] [PATCH] D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure

[Peter Klausler via Phabricator via flang-commits]

klausler accepted this revision.
klausler added a comment.

Looks great to me; thanks!



================
Comment at: flang/docs/Intrinsics.md:711
+
+f18 will always consider this is the intrinsic and emit errors, unless the procedure is used as
+a function (resp. subroutine) and the intrinsic is a subroutine (resp. function).
----------------
English: "f18 will always consider this case to be the intrinsic..."


================
Comment at: flang/docs/Intrinsics.md:724
+
+The rational for f18 behavior is that when referring to a procedure with an
+argument number or type that does not match the intrinsic specification, it seems safer to block
----------------
sp. "rationale".


================
Comment at: flang/docs/Intrinsics.md:734
+Also note that in general, the standard gives the compiler the right to consider
+any procedures that is not explicitly external as a non standard intrinsic (section 4.2 point 4).
+So it is highly advised for the programmer to use EXTERNAL statements to raise any ambiguity.
----------------
"procedure" should be singular


================
Comment at: flang/docs/Intrinsics.md:735
+any procedures that is not explicitly external as a non standard intrinsic (section 4.2 point 4).
+So it is highly advised for the programmer to use EXTERNAL statements to raise any ambiguity.
+
----------------
"resolve" or "prevent" or "forestall", not "raise"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90049/new/

https://reviews.llvm.org/D90049