[flang-commits] [PATCH] D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure

[Jean Perier via Phabricator via flang-commits]

jeanPerier created this revision.
jeanPerier added reviewers: klausler, sscalpone, tskeith.
jeanPerier added a project: Flang.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.
jeanPerier requested review of this revision.

2 Bug fixes:

- Do not resolve procedure as intrinsic if they appeared in an EXTERNAL attribute statement (one path was not considering this flag)

- Emit an error if a procedure resolved to be an intrinsic function (resp. subroutine) is used as a subroutine (resp. function). Lowering was attempted while the evaluate::Expression for the call was missing without any errors.

1 behavior change:

- Do not implicitly resolve subroutines (resp. functions) as intrinsics because their name is the name of an intrinsic function (resp. subroutine). Add justification in documentation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90049

Files:
  flang/docs/Intrinsics.md
  flang/include/flang/Evaluate/intrinsics.h
  flang/lib/Evaluate/intrinsics.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/test/Semantics/call16.f90
  flang/test/Semantics/symbol19.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90049.300307.patch
Type: text/x-patch
Size: 12771 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20201023/66222aad/attachment-0001.bin>