[flang-commits] [PATCH] D89583: [Flang][OpenMP] Semantic checks for Atomic construct.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi created this revision.
sameeranjoshi added reviewers: kiranchandramohan, clementval, kiranktp, SouraVX.
Herald added subscribers: jfb, guansong, yaxunl.
Herald added a reviewer: sscalpone.
Herald added a project: LLVM.
sameeranjoshi requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

Patch implements restrictions from 2.17.7  of OpenMP 5.0 standard for atomic Construct. Tests for the same are added.

There is a todo for Hint clause restriction which I was unable to figure out as Hint is currently not found in `actualClauses` list.

One of the restriction
`OpenMP constructs may not be encountered during execution of an atomic region.`
Is mentioned in 5.0 standard to be a semantic restriction, but given the stricter nature of parser in F18 <https://reviews.llvm.org/F18> it's caught at parsing itself.

This patch is a next patch in series from D88965 <https://reviews.llvm.org/D88965>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89583

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/test/Semantics/omp-atomic01.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89583.298708.patch
Type: text/x-patch
Size: 14640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20201016/87cb9e76/attachment.bin>