[flang-commits] [PATCH] D89473: [flang] Document and use intrinsic subroutine argument intents

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/include/flang/Evaluate/characteristics.h:236
   void SetOptional(bool = true);
+  bool HasIntent(common::Intent) const;
+  void SetIntent(common::Intent);
----------------
Another possibility: implement a `GetIntent()`, then implement `HasIntent()` using `GetIntent()` or with comparisons.


================
Comment at: flang/lib/Semantics/check-call.cpp:316
   }
-  if (actualLastObject && actualLastObject->IsCoarray() &&
+  if (!isIntrinsicCall && actualLastObject && actualLastObject->IsCoarray() &&
       IsAllocatable(*actualLastSymbol) &&
----------------
Are all ALLOCATABLE coarrays really acceptable as actual arguments to `INTENT(OUT)` intrinsic subroutine arguments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89473/new/

https://reviews.llvm.org/D89473