[flang-commits] [PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

Kiran Chandramohan via Phabricator via flang-commits flang-commits at lists.llvm.org
Tue Oct 13 02:21:08 PDT 2020


kiranchandramohan added a comment.

> IIUC, it's partially correct.
> The allowedClauses which are currently present in OMP.td will work in catching the test cases which don't obey what OMP.td has defined.
> e.g for test cases with num_threads clause, which is not found in allowedClauses of def OMP_Atomic is caught in parsing stage.

A test for this might be good with this patch itself.

Thanks for the replies. No further questions from my side. I have already approved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965



More information about the flang-commits mailing list