[flang-commits] [PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi marked an inline comment as done.
sameeranjoshi added a comment.

In D88965#2321734 <https://reviews.llvm.org/D88965#2321734>, @kiranchandramohan wrote:

>>> BTW, are allowed clauses and all handled automatically or will they require a separate patch?
>>
>> I think semantic checks for atomic needs separate patch which might need to upgrade to OpenMP 5.0 changes.
>
> If semantic checks for 4.5 clauses don't automatically work then there is a regression since previously the parser correctly only allowed MemoryOrder Clauses. Now that we have generalized to OmpClause for Atomic, it might be better to add tests for semantic checks in this patch itself.

There are no semantic checks for even 4.5 as well nor any tests.
It needs more work which I think should be better to come with a new patch specific to semantic checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965