[flang-commits] [PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

sameeran joshi via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Oct 8 00:37:08 PDT 2020


sameeranjoshi updated this revision to Diff 296879.
sameeranjoshi added a comment.

1. Revert `OmpClauseList` back to `std::optional<OmpClause>`.

Sorry a copy paste typo.

2. Add unparse tests.

Why do we need unparser tests here, as unparsing would be removed at some point
in time? So should the tests be removed at that time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965

Files:
  flang/include/flang/Parser/dump-parse-tree.h
  flang/include/flang/Parser/parse-tree.h
  flang/lib/Parser/openmp-parsers.cpp
  flang/lib/Parser/unparse.cpp
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/test/Parser/omp-atomic-unparse.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88965.296879.patch
Type: text/x-patch
Size: 20936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20201008/21808913/attachment-0001.bin>


More information about the flang-commits mailing list