[flang-commits] [PATCH] D82695: [flang] Roll up work on external I/O runtime library

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Jun 29 08:03:44 PDT 2020


klausler abandoned this revision.
klausler added a comment.

In D82695#2119300 <https://reviews.llvm.org/D82695#2119300>, @richard.barton.arm wrote:

> Please can this patch be split up into separate patches for each of the separate types changes? Roll-up patches are not good practice and against the developer policy <https://llvm.org/docs/DeveloperPolicy.html#incremental-development>. 
>  @PeteSteinfeld The patches should also be code reviewed for LLVM master. Prior review on some other project is not relevant and should not be given as justification for approving patches to LLVM master.
>  The clang-tidy linting errors also need fixing up.
>
> Thanks


I'm happy to not push this code if you don't want it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82695/new/

https://reviews.llvm.org/D82695





More information about the flang-commits mailing list