[flang-commits] [PATCH] D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0

Kiran Kumar T P via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jun 24 21:42:16 PDT 2020


kiranktp added a comment.

> Lint: Pre-merge checks

/mnt/disks/ssd0/agent/llvm-project/flang/lib/Semantics/check-omp-structure.cpp:671:18: warning: invalid case style for variable 'allowed' [readability-identifier-naming]

  OmpClauseSet allowed{OmpClause::DEPEND};
               ^~~~~~~
               Allowed

I think I can neglect this warning as i have used the correct naming convention for the variable.
Local variables names should start with lower case. The same has been used in multiple places in the same file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82255/new/

https://reviews.llvm.org/D82255





More information about the flang-commits mailing list