[flang-commits] [PATCH] D79851: [Flang] Semantics for SELECT TYPE

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/check-select-type.cpp:126-127
+      if (const semantics::Scope * guardScope{derived.typeSymbol().scope()}) {
+        const auto *selDerivedTypeSpec{
+            evaluate::GetDerivedTypeSpec(selectorType_)};
+        if (selDerivedTypeSpec) {
----------------
You should embed the declaration of `selDerivedTypeSpec` into the `if` condition to reduce its scope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79851/new/

https://reviews.llvm.org/D79851