[flang-commits] [PATCH] D80377: [flang] Google test infrastructure support for unittests

Mon Jun 8 13:52:07 PDT 2020

sameeranjoshi marked 5 inline comments as done.
sameeranjoshi added a subscriber: isuruf.
sameeranjoshi added inline comments.

================
Comment at: flang/runtime/io-error.cpp:10
 #include "io-error.h"
-#include "config.h"
 #include "magic-numbers.h"
----------------
tskeith wrote:
> sameeranjoshi wrote:
> > tskeith wrote:
> > > sameeranjoshi wrote:
> > > > tskeith wrote:
> > > > > Is this supposed to be part of your change?
> > > > Yes, out-of-tree builds fail with this include.
> > > > Also see this commit addressing the same
> > > > https://github.com/flang-compiler/f18-llvm-project/commit/4069068c997812c1c8ef6434a5e630603c7232e0
> > > > 
> > > This should be in a separate change. It has nothing to do with google test infrastructure.
> > > 
> > > The include of config.h was added for a reason. Does that reason no longer apply or are you breaking something else by changing this?
> > I could build and test successfully with removing this file for out of tree and in tree.
> > Can you mention what does "something else" mean here or for what specific reason was this added ?
> You can answer this question with `git log`:
> 
> ```
> commit ea5efd1ea87e3d6b86a8e7f940f94dec0a90a004
> Author: Isuru Fernando <isuruf at gmail.com>
> Date:   Thu Mar 12 15:28:35 2020 -0500
> 
>     [flang] Support platforms without strerror_r
> 
>     Original-commit: flang-compiler/f18 at 0575b54cc79110ae03f73b136e704f6313e2d63f
>     Reviewed-on: https://github.com/flang-compiler/f18/pull/1068
> ```
Addressed by https://reviews.llvm.org/D81266
Thanks @isuruf 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377