[flang-commits] [PATCH] D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic.

Pete Steinfeld via Phabricator via flang-commits flang-commits at lists.llvm.org
Tue Jul 28 07:00:30 PDT 2020


PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

All builds, tests, and looks good.

Thanks for doing this!



================
Comment at: flang/lib/Semantics/check-select-type.cpp:83
+              const DeclTypeSpec *spec{typeSpec.declTypeSpec};
+              bool typeSpecRetVal{false};
+              CHECK(spec);
----------------
Please move the declaration of `typeSpecRetVal` below the calls to `CHECK()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84290/new/

https://reviews.llvm.org/D84290



More information about the flang-commits mailing list