[flang-commits] [PATCH] D84334: Version information in flang/f18

Mon Jul 27 09:42:22 PDT 2020

gak added a comment.

In D84334#2176184 <https://reviews.llvm.org/D84334#2176184>, @AlexisPerry wrote:

> In D84334#2173076 <https://reviews.llvm.org/D84334#2173076>, @naromero77 wrote:
>
> > I am assuming that f18 will have a MAJOR version number matching the LLVM release? Does classic flang do that as well? Both compilers will probably co-exist for a while and it would be desirable to make them distinguishable to build systems as CMake.
> >
> > I don't have a solution, but maybe we need to `#define __CLASSIC_FLANG` in classic flang.  I am just throwing out ideas.
>
>
> I agree with this idea, and if we went this route we could get rid of the duplicate code between `__F18_MAJOR` and `__FLANG_MAJOR` (and the others) included in this patch.  We would have to coordinate with the Classic Flang developers to make it happen, though, and I'm not sure if they are aware of the discussion happening here.

At least one is. I think the idea of defining __CLASSIC_FLANG in the compiler is a good one.

Classic Flang's version numbering started out unrelated to the LLVM version numbering. I am not sure how we should change it to align yet, but it's something we can look into.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334