[flang-commits] [PATCH] D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic.

Inderjeet via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jul 22 05:46:34 PDT 2020


inderjeet-hcl added a comment.

@sameeranjoshi. I missed to reply for below points, kindly find the reply below.

> Can you add checks with !ERROR: in the respective files?

I will add '!ERROR:' and share updated test programs.

> Also I never saw someone sending a .patch file for review separately in llvm-project, you need to include the changes with the revision itself.

Please note that I referred following point in document(https://www.llvm.org/docs/Phabricator.html#code-reviews-with-phabricator) to submit the patch. Kindly let me know if any other method needs to be following to share modified source files and test programs.
"Note that you can upload patches created through git,"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84290/new/

https://reviews.llvm.org/D84290





More information about the flang-commits mailing list