[flang-commits] [PATCH] D83808: [flang] Refine CR handling

Wed Jul 15 06:45:18 PDT 2020

fhahn added a comment.

In D83808#2153101 <https://reviews.llvm.org/D83808#2153101>, @sscalpone wrote:

> In D83808#2152697 <https://reviews.llvm.org/D83808#2152697>, @fhahn wrote:
>
> > It sounds like this fixes a problem. Would it be possible to add a test?
>
>
> The FCVS test FM363 covers the issue.  It would be helpful for the commit message to refer to the test.

I see, but would it be hard to add such a unit test to the flang parser tests in tree? An external test suite is great, but most code should also be covered by unit-tests, unless it is not possible to do so.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83808/new/

https://reviews.llvm.org/D83808