[flang-commits] [PATCH] D83488: [flang] Change the default F18_FC to gfortran

[Alexis Perry-Holby via Phabricator via flang-commits]

AlexisPerry marked an inline comment as done.
AlexisPerry added a comment.

@richard.barton.arm I have made the requested adjustments in the other patch.  Thanks for the feedback!



================
Comment at: flang/tools/f18/f18.cpp:636
   if (options.features.IsEnabled(Fortran::common::LanguageFeature::OpenMP)) {
-    driver.pgf90Args.push_back("-mp");
+    driver.F18_FCArgs.push_back("-mp");
   }
----------------
richard.barton.arm wrote:
> This needs to be amended to support gfortran. We'd need a similar switch on `isPGF90` to pass `-fopenmp` here. I think it might work better to be moved into the next if/else block so it can be set to gfortran/pgfortran there. 
> 
> Might also be better to add this as part of D83687 rather than this patch.
I agree this would be better as part of D83687, so I will add the fix over there.  Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83488/new/

https://reviews.llvm.org/D83488