[flang-commits] [PATCH] D83488: [flang] Change the default F18_FC to gfortran

[Richard Barton via Phabricator via flang-commits]

richard.barton.arm added a comment.

Thanks for picking up the work on this one @AlexisPerry!

I have replied to the RFC (late - my apologies) with a slightly different proposal. I'd like to make a final decision at the developers call on Monday. I don't hold my position too strongly though and would be happy to go in this direction. I also think we can go ahead with this patch because it moves us to a better place than we are now. Even if we chose my proposal to have no default most of this patch would still be kept because having gfortran support is a useful feature anyway.

On the patch itself, I have two requests:

1. This patch seems to be doing a couple of different things now that don't seem to be strictly linked:
  - Switching the default F18_FC to gfortran
  - Add support for a number of new gfortran options

I think these would be better submitted as two patches. Do you agree?

2. The patch should add a regression test for these fallback and option translation behaviours in test/Driver. It is a shame there are none already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83488/new/

https://reviews.llvm.org/D83488